Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

feat(lanelet2_extension): add regulatory element details checker #237

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

feat(lanelet2_extension): add regulatory element details checker #237

wants to merge 34 commits into from

Conversation

sgk-000
Copy link

@sgk-000 sgk-000 commented Feb 6, 2024 •
edited
Loading

Description

Added regulatory element details checker to autoware_lanelet2_validation package.
This PR is an extension of #235. Please start the review of this PR only after #235 has been merged. Probably, this branch will be rebased.

Related links

Not applicable.

Tests performed

Please run

ros2 run lanelet2_extension autoware_lanelet2_validation --map_file <path/to/map.osm> --validator mapping.regulatory_elements_details

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

sgk-000 and others added 30 commits February 2, 2024 14:09
@sgk-000
Added autoware_lanenet2_validation
e3e81ac 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added autoware_lanelet2_validation to cmake
546bf3c 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Splited unconnected_relations checker to missing regulatory elements …
b34790b 
…checker and regulatory element details checker

Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added test for missing regulatory elements checker
e5d01f7 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added test of missing regulatory elements checker to cmake
1f0d928 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added license and copyright notice
aa0d33f 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Refactored
da970b0 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Removed unnecessary files
bea8df7 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Change default projector to MGRS projector
c047c3d 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Updated help messages in cli
9d8d286 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Removed local from projector option
9646c34 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Updated help message to be more readable
2dfe7e3 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added document for autoware_lanelet2_validation
3c7bf70 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added simple_lanelet2_validation
bafae94 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Updated help description to warn if lat or lon is not set when projec…
6a28437 
…tor is utm or transverse mercator

Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Used move_iterator
54da3d6 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@pre-commit-ci @sgk-000
style(pre-commit): autofix
4e72c8d
@sgk-000
Made fenced code blocks to have language specified context
df4f04d 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added include guard
874b4e2 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Rename validators directory to vals because include guard name too long
ac974db 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Removed unnecessary namespace
a34c8d3 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Add static cast
c597752 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Fixed include guard name
ecc58a8 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Removed explicitly operetor call
c2ac49d 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added missed namespace
4a1b85c 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added template for append_issue
160a942 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Check missing regulatory elements in stop lines
b4ca2fd 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added regulatory element details checker
13bd2f2 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added copyright and license notice
1d0d25f 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Updated comments
ae7ec07 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Fixed bug of the issue which is reported when ref line of traffic lig…
54bee13 
…ht regulatory element does not have type of stop line

Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added more test case
530dc9b 
Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Added TODO comment. Check if regulatory element of traffic light must…
f17a8a9 
… have stop line or crosswalk

Signed-off-by: Shigeki Kobayashi <[email protected]>
@sgk-000
Report error if traffic light regulatory element does not have stop l…
5e08fad 
…ine and this is not a pedestrian traffic light

Signed-off-by: Shigeki Kobayashi <[email protected]>
@stale Stale
Copy link

stale bot commented Apr 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 will be requested when the pull request is marked ready for review kosuke55 is a code owner

@soblin soblin Awaiting requested review from soblin soblin will be requested when the pull request is marked ready for review soblin is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san will be requested when the pull request is marked ready for review Motsu-san is a code owner

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r will be requested when the pull request is marked ready for review mitsudome-r is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 will be requested when the pull request is marked ready for review takayuki5168 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sgk-000