[DO NOT MERGE] test unnecessary clang tidy #253
Conversation
Signed-off-by: Takayuki Murooka <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -377,7 +377,7 @@ BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) | |||
There was a problem hiding this comment.
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
| getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) | |
| explicit getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) |
| @@ -377,7 +377,7 @@ | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) | |||
There was a problem hiding this comment.
single-argument constructors must be marked explicit to avoid unintentional implicit conversions
| getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) | |
| explicit getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) |
| @@ -377,7 +377,7 @@ | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 1, 3) | |||
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 2, 3) | |||
There was a problem hiding this comment.
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 2, 3) | |
| explicit overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 2, 3) |
| @@ -377,7 +377,7 @@ | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 1, 3) | |||
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 2, 3) | |||
There was a problem hiding this comment.
single-argument constructors must be marked explicit to avoid unintentional implicit conversions
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 2, 3) | |
| explicit overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 2, 3) |
| @@ -377,7 +377,7 @@ | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 1, 3) | |||
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 2, 3) | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS(isInLanelet_overload, ::isInLanelet, 2, 3) | |||
There was a problem hiding this comment.
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
| BOOST_PYTHON_FUNCTION_OVERLOADS(isInLanelet_overload, ::isInLanelet, 2, 3) | |
| BOOST_PYTHON_FUNCTION_OVERLOADS(explicit isInLanelet_overload, ::isInLanelet, 2, 3) |
| @@ -377,7 +377,7 @@ | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| getLeftBoundWithOffset_overload, lanelet::utils::getLeftBoundWithOffset, 2, 3) | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS( | |||
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 1, 3) | |||
| overwriteLaneletsCenterline_overload, lanelet::utils::overwriteLaneletsCenterline, 2, 3) | |||
| BOOST_PYTHON_FUNCTION_OVERLOADS(isInLanelet_overload, ::isInLanelet, 2, 3) | |||
There was a problem hiding this comment.
single-argument constructors must be marked explicit to avoid unintentional implicit conversions
| BOOST_PYTHON_FUNCTION_OVERLOADS(isInLanelet_overload, ::isInLanelet, 2, 3) | |
| BOOST_PYTHON_FUNCTION_OVERLOADS(explicit isInLanelet_overload, ::isInLanelet, 2, 3) |
Description
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.