Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(map): rework parameters of map #843

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

anhnv3991
Copy link
Contributor

Description

Add reference to parameters from launch files to the YAML files under config/map/

Tests performed

  • From autoware.universe, switched to chore/rework_param_map_loader
  • Launched logging simulator
    Output
    Screenshot from 2024-02-01 17-12-21

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@SakodaShintaro SakodaShintaro changed the title chore(map): Rework parameters of map chore(map): rework parameters of map Feb 2, 2024
@anhnv3991 anhnv3991 merged commit 668c9b0 into autowarefoundation:main Feb 7, 2024
8 of 10 checks passed
t4-adc pushed a commit to tier4/autoware_launch that referenced this pull request Mar 21, 2024
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 3, 2024
technolojin pushed a commit to technolojin/autoware_launch that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants