Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driving_environment_analyzer): fixed depend pkg name about behavior_path_planner_common #36

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Jun 6, 2024

Description

Fixes for adding the autoware_ prefix

Tests performed

before

~/autoware$ rosdep install -y --from-paths src --ignore-src --rosdistro humble
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
driving_environment_analyzer: Cannot locate rosdep definition for [behavior_path_planner_common]

after

~/autoware$ rosdep install -y --from-paths src --ignore-src --rosdistro humble
#All required rosdeps installed successfully

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ehavior_path_planner_common

Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro SakodaShintaro enabled auto-merge (squash) June 6, 2024 07:59
Signed-off-by: satoshi-ota <[email protected]>
@yabuta
Copy link
Contributor

yabuta commented Jun 7, 2024

@SakodaShintaro I think it may be better to add rosbag2_cpp depend in this PR.
I failed to build below error.

In file included from /home/yabuta/workspace/autoware_tools/driving_environment_analyzer/include/driving_environment_analyzer/driving_environment_analyzer_rviz_plugin.hpp:18,
                 from /home/yabuta/workspace/autoware_tools/driving_environment_analyzer/src/driving_environment_analyzer_rviz_plugin.cpp:15:
/home/yabuta/workspace/autoware_tools/driving_environment_analyzer/include/driving_environment_analyzer/analyzer_core.hpp:19:10: fatal error: rosbag2_cpp/reader.hpp: No such file or directory
   19 | #include "rosbag2_cpp/reader.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Should I submit it under a different PR?

@satoshi-ota
Copy link
Contributor

@SakodaShintaro I think it may be better to add rosbag2_cpp depend in this PR. I failed to build below error.

In file included from /home/yabuta/workspace/autoware_tools/driving_environment_analyzer/include/driving_environment_analyzer/driving_environment_analyzer_rviz_plugin.hpp:18,
                 from /home/yabuta/workspace/autoware_tools/driving_environment_analyzer/src/driving_environment_analyzer_rviz_plugin.cpp:15:
/home/yabuta/workspace/autoware_tools/driving_environment_analyzer/include/driving_environment_analyzer/analyzer_core.hpp:19:10: fatal error: rosbag2_cpp/reader.hpp: No such file or directory
   19 | #include "rosbag2_cpp/reader.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Should I submit it under a different PR?

@yabuta I'll add deps right away.

Signed-off-by: satoshi-ota <[email protected]>
@satoshi-ota satoshi-ota force-pushed the fix/fix_depend_pkg_name_in_driving_envirinment_analyzer branch from e687f89 to 685c31c Compare June 7, 2024 09:44
@SakodaShintaro SakodaShintaro disabled auto-merge June 10, 2024 05:51
@SakodaShintaro SakodaShintaro merged commit 6c31a30 into autowarefoundation:main Jun 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants