Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driving_environment_analyzer): fix dependency and code related to route_handler #38

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Jun 7, 2024

Description

Fixes for adding autoware_ prefix to route handler

Tests performed

Notes for reviewers

Should be merged after linked PR is closed.

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mkquda mkquda requested review from satoshi-ota and yukkysaito June 7, 2024 06:39
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkquda LGTM! Thank you.

@satoshi-ota satoshi-ota enabled auto-merge (squash) June 11, 2024 02:53
@satoshi-ota satoshi-ota merged commit 591af71 into main Jun 11, 2024
26 checks passed
@satoshi-ota satoshi-ota deleted the fix-route-handler-includes-and-access branch June 11, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants