-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_control_rviz_plugin): change to read topic by polling and add missing subscriber #51
feat(tier4_control_rviz_plugin): change to read topic by polling and add missing subscriber #51
Conversation
Signed-off-by: Autumn60 <[email protected]>
…lingSubscriber Signed-off-by: Autumn60 <[email protected]>
I've fixed the CI issue with the build-and-test-differential workflow: So I'm updating this to
Also the codeowners are updated, at least one approval from them is required. If you are experienced in this package, you may add yourself to package maintainer list too. |
I will wait a bit to merge this PR as I expect build failures due to changes in autowarefoundation/autoware.universe#7538. @xmfcx |
….xml Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
@taikitanaka3 |
waiting for #59 to be merged |
Signed-off-by: Autumn60 <[email protected]>
Description
Based on the discussion, change
tier4_control_rviz_plugin
to read topic by polling instead of best_effort callback.and
Add missing subscriber for
geometry_msgs::msg::AccelWithCovarianceStamped
Related links
https://github.com/orgs/autowarefoundation/discussions/4612
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.