Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_control_rviz_plugin): change to read topic by polling and add missing subscriber #51

Merged
merged 11 commits into from
Jun 20, 2024

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Jun 14, 2024

Description

Based on the discussion, change tier4_control_rviz_plugin to read topic by polling instead of best_effort callback.

and

Add missing subscriber for geometry_msgs::msg::AccelWithCovarianceStamped

Related links

https://github.com/orgs/autowarefoundation/discussions/4612

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx closed this Jun 17, 2024
@xmfcx xmfcx reopened this Jun 17, 2024
@xmfcx xmfcx requested a review from taikitanaka3 as a code owner June 17, 2024 19:39
@xmfcx
Copy link
Contributor

xmfcx commented Jun 17, 2024

I've fixed the CI issue with the build-and-test-differential workflow:

So I'm updating this to main branch.

build-and-test-differential workflow should now work as expected.

Also the codeowners are updated, at least one approval from them is required.

If you are experienced in this package, you may add yourself to package maintainer list too.

@Autumn60
Copy link
Contributor Author

I will wait a bit to merge this PR as I expect build failures due to changes in autowarefoundation/autoware.universe#7538.

@xmfcx
Thank you for fixing the build-and-test-diff CI.
Also, I will add myself to the package maintainer with your suggestion. 🙏

@Autumn60
Copy link
Contributor Author

@taikitanaka3
Could you review this PR as a code owner?

@Autumn60
Copy link
Contributor Author

waiting for #59 to be merged

@Autumn60 Autumn60 enabled auto-merge (squash) June 20, 2024 04:38
@Autumn60 Autumn60 merged commit 9ca4a4e into main Jun 20, 2024
17 checks passed
@Autumn60 Autumn60 deleted the feat/tier4_control_rviz_plugin/sub_by_polling branch June 20, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants