Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(route_handler)!: include autoware_route_handler #54

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 17, 2024

Description

autowarefoundation/autoware.universe#7530

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 requested a review from takayuki5168 June 17, 2024 17:38
@xmfcx xmfcx closed this Jun 17, 2024
@xmfcx xmfcx reopened this Jun 17, 2024
@xmfcx xmfcx requested a review from satoshi-ota as a code owner June 17, 2024 19:39
@xmfcx
Copy link
Contributor

xmfcx commented Jun 17, 2024

I've fixed the CI issue with the build-and-test-differential workflow:

So I'm updating this to main branch.

build-and-test-differential workflow should now work as expected.

Also the codeowners are updated, at least one approval from them is required.

If you are experienced in this package, you may add yourself to package maintainer list too.

@kosuke55 kosuke55 merged commit 55eab43 into main Jun 18, 2024
21 checks passed
@kosuke55 kosuke55 deleted the feat/autoware_route_handler branch June 18, 2024 00:01
xtk8532704 pushed a commit that referenced this pull request Jun 19, 2024
Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants