fix(perception_replayer): support two kinds of old messages in rosbags #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtk8532704
changed the title
…be converted to new type correctly (#60) * ensure that old message in rosbagcan be converted to new type correctly. Signed-off-by: temkei.kem <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: temkei.kem <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: temkei.kem <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
xtk8532704
force-pushed
the
fix/perception_replayer/convert_old_rosbag2
branch
from
1ccc01d to
548acbd
Compare
xtk8532704
requested review from
taikitanaka3,
TakaHoribe and
takayuki5168
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the previous PR, I incorrectly assumed that the code for converting old messages was wrong.
But in fact, there are two old messages with the same name
TrafficSignalArray, so this PR aim to support both old messages.Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.