Fix merkledb rebuild iterator (#2581)

ava-labs · Jan 4, 2024 · 72dc442 · 72dc442
1 parent 935bfe4
commit 72dc442
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/x/merkledb/db.go b/x/merkledb/db.go
@@ -336,7 +336,8 @@ func (db *merkleDB) rebuild(ctx context.Context, cacheSize int) error {
 	)
 	currentOps := make([]database.BatchOp, 0, opsSizeLimit)
 	valueIt := db.NewIterator()
-	defer valueIt.Release()
+	// ensure valueIt is captured and release gets called on the latest copy of valueIt
+	defer func() { valueIt.Release() }()
 	for valueIt.Next() {
 		if len(currentOps) >= opsSizeLimit {
 			view, err := newView(db, db, ViewChanges{BatchOps: currentOps, ConsumeBytes: true})