Remove cached node bytes from merkle nodes #2393
Conversation
Co-authored-by: Dan Laine <[email protected]> Signed-off-by: David Boehm <[email protected]>
Not explicitly. This is mostly to reduce the size of cache entries since they currently store the node's bytes twice, once as the raw bytes and once in the various fields on the node struct. Removing this extra copy with roughly halve the memory footprint per node, so we should be able to store almost twice the nodes in the cache. |
| @@ -66,17 +64,7 @@ func (n *node) hasValue() bool { | |||
|
|
|||
| // Returns the byte representation of this node. | |||
| func (n *node) bytes() []byte { | |||
| if n.nodeBytes == nil { | |||
There was a problem hiding this comment.
Removing this cached value means we'll have to reserialize the node before writing it. Are we concerned about the additional time that'll take? Seems to be a tradeoff between memory usage and CPU usage.
There was a problem hiding this comment.
anything we are writing is something we edited so this would have always been nil
We mostly load nodes just before we edit them, so holding on to the bytes just wastes memory.