vms/platformvm: Process atomicRequests and onAcceptFunc in option blocks
#2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
StephenButtolph
approved these changes
Dec 11, 2023
abi87
previously requested changes
Dec 11, 2023
There was a problem hiding this comment.
@StephenButtolph should we evaluate the altenative design in #2439 before merging this?
dhrubabasu
dismissed
abi87’s stale review
isn't a review but should be discussed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Once
ProposalBlocks contain decision txs, these fields will be populated. We must duly process them.This is a no-op change currently as these fields are not populated.
Factored out of #2451
How this works
standardBlockfunction.atomicRequests,inputs,onAcceptFuncHow this was tested
CI