-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add networked-signer tests #3613
Open
richardpringle
wants to merge
39
commits into
master
Choose a base branch
from
encapsulate-signer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 32 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
321dd52
Move local-signer to its own package
richardpringle b731e7e
Prepare bls-tests for multiple signer-types
richardpringle 435d116
Add test for networked signer
richardpringle a2ab5d4
Expose secret-key-length from the bls package
richardpringle 7f49c85
Rename signers/local to signers/localsigner
richardpringle 9ad13b2
Remove redundant comment
richardpringle 9fd0c12
Rename local.go to localsigner.go
richardpringle 67885b3
Rename bls_test to blstest
richardpringle 65d61a0
Rename bls/test dir to blstest
richardpringle 77367f2
Revert "Rename bls/test dir to blstest"
richardpringle eeb846a
Revert "Rename bls_test to blstest"
richardpringle 7027a47
Fix bls tests
richardpringle 18d1f7c
Follow test package pattern from the rest of the repo
richardpringle c4170e7
Revert "Follow test package pattern from the rest of the repo"
richardpringle 1532698
Use blstest convention
richardpringle db266c6
Merge remote-tracking branch 'origin/master' into encapsulate-signer
richardpringle 988920f
Fix accidental search-and-replace
richardpringle 8885a5c
Fix remaining references to old bls methods
richardpringle 1ca1be1
Add updated coreth
richardpringle 41830aa
Update tests to use localsigner
richardpringle 6844aeb
Merge remote-tracking branch 'origin/master' into encapsulate-signer
richardpringle d92c69c
Fix SecretKeyFromBytes
richardpringle a679b44
Fix linter errors
richardpringle 67bc45b
More lint fixes
richardpringle 44814bd
Reset tree.go file
richardpringle 695329f
Add missing license header
richardpringle 885230d
More lint-fixes
richardpringle 9fdfe99
Merge remote-tracking branch 'origin/master' into encapsulate-signer
richardpringle 9d25f68
Merge remote-tracking branch 'origin/master' into encapsulate-signer
richardpringle 494864f
Fix bls-tests
richardpringle 3b7858b
Make sure there are signers for the test
richardpringle 75c98c5
More bls-test fixes
richardpringle 5835988
Reset config/config.md
richardpringle 1bca3ef
Split bls tests
richardpringle a723269
Merge remote-tracking branch 'origin/master' into encapsulate-signer
richardpringle 3c1ce6c
Move bls public_test.go back into the bls package
richardpringle ad10cb2
Move bls-tests back to bls package
richardpringle 0533b15
Fix linting
richardpringle a429a32
Add missing license headers
richardpringle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: undo diff in this line since it's unrelated