Add L1 validator fees API #3647
Merged
+304
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
arturrez
approved these changes
Jan 14, 2025
meaghanfitzgerald
requested changes
Jan 14, 2025
Signed-off-by: Meaghan FitzGerald <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Comment on lines
+11
to
+12
| - Removed: | ||
| - `info.GetTxFee` |
There was a problem hiding this comment.
was this affected by the rollback?
There was a problem hiding this comment.
No - that is unrelated to this PR
meaghanfitzgerald
approved these changes
Jan 16, 2025
Co-authored-by: Meaghan FitzGerald <[email protected]> Signed-off-by: Stephen Buttolph <[email protected]>
Co-authored-by: Meaghan FitzGerald <[email protected]> Signed-off-by: Stephen Buttolph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently it is difficult to learn what the current fee is for L1 validators.
How this works
Adds APIs:
platform.getValidatorFeeConfigplatform.getValidatorFeeStateIt was decided against modifying the existing APIs
platform.getFeeConfigandplatform.getFeeStatebecause that would have made the types more complex.How this was tested
Added unit tests similar to
platform.getFeeConfigandplatform.getFeeState.Need to be documented in RELEASES.md?
Documented the new APIs in both
service.mdandRELEASES.md.