test: fix failing test

ava-labs · Jan 8, 2025 · c938f76 · c938f76
1 parent 502b25f
commit c938f76
Showing 1 changed file with 55 additions and 7 deletions.
diff --git a/src/background/services/wallet/handlers/importLedger.test.ts b/src/background/services/wallet/handlers/importLedger.test.ts
@@ -106,7 +106,7 @@ describe('src/background/services/wallet/handlers/importLedger', () => {
       xpub: xpubValue,
       xpubXP: xpubXPValue,
       name: nameValue,
-      numberOfAccountsToCreate: 1,
+      numberOfAccountsToCreate: 2,
     });
 
     expect(walletService.addPrimaryWallet).toHaveBeenCalledWith({
@@ -117,8 +117,7 @@ describe('src/background/services/wallet/handlers/importLedger', () => {
       name: nameValue,
     });
 
-    // correlate to numberOfAccountsToCreate
-    expect(accountsService.addPrimaryAccount).toHaveBeenCalledTimes(1);
+    expect(accountsService.addPrimaryAccount).toHaveBeenCalledTimes(2);
 
     expect(accountsService.activateAccount).toHaveBeenCalledTimes(1);
 
@@ -128,7 +127,8 @@ describe('src/background/services/wallet/handlers/importLedger', () => {
       id: walletId,
     });
   });
-  it('returns an ImportWalletResult if LedgerLive import is successful', async () => {
+
+  it('only imports accounts with pubkeys', async () => {
     const walletId = crypto.randomUUID();
     const pubKeysValue = [
       {
@@ -160,9 +160,7 @@ describe('src/background/services/wallet/handlers/importLedger', () => {
       name: nameValue,
     });
 
-    // correlate to numberOfAccountsToCreate
-    expect(accountsService.addPrimaryAccount).toHaveBeenCalledTimes(2);
-
+    expect(accountsService.addPrimaryAccount).toHaveBeenCalledTimes(1);
     expect(accountsService.activateAccount).toHaveBeenCalledTimes(1);
 
     expect(result).toEqual({
@@ -171,4 +169,54 @@ describe('src/background/services/wallet/handlers/importLedger', () => {
       id: walletId,
     });
   });
+
+  it('imports max 3 accounts', async () => {
+    const walletId = crypto.randomUUID();
+    const pubKeysValue = [
+      {
+        evm: 'pubKeyEvm1',
+      },
+      {
+        evm: 'pubKeyEvm2',
+      },
+      {
+        evm: 'pubKeyEvm3',
+      },
+      {
+        evm: 'pubKeyEvm4',
+      },
+    ];
+    const nameValue = 'walletName';
+    secretsService.isKnownSecret.mockResolvedValueOnce(false);
+    walletService.addPrimaryWallet.mockResolvedValue(walletId);
+    secretsService.getWalletAccountsSecretsById.mockResolvedValue({
+      secretType: SecretType.LedgerLive,
+      pubKeys: pubKeysValue,
+      derivationPath: DerivationPath.LedgerLive,
+      id: walletId,
+      name: nameValue,
+    });
+
+    const { result } = await handle({
+      secretType: SecretType.LedgerLive,
+      pubKeys: pubKeysValue,
+      name: nameValue,
+      numberOfAccountsToCreate: 4,
+    });
+
+    expect(walletService.addPrimaryWallet).toHaveBeenCalledWith({
+      secretType: SecretType.LedgerLive,
+      pubKeys: pubKeysValue,
+      derivationPath: DerivationPath.LedgerLive,
+      name: nameValue,
+    });
+
+    expect(accountsService.addPrimaryAccount).toHaveBeenCalledTimes(3);
+
+    expect(result).toEqual({
+      type: SecretType.LedgerLive,
+      name: nameValue,
+      id: walletId,
+    });
+  });
 });