[CP-9405] app authorization token #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bferenc
commented
Dec 12, 2024
| } | ||
| return swRegistration.pushManager.subscribe({ | ||
| - userVisibleOnly: true, | ||
| + userVisibleOnly: false, |
There was a problem hiding this comment.
Chrome allows it since 121, but the SDK doesn't support it yet.
gergelylovas
previously approved these changes
Dec 16, 2024
| } | ||
|
|
||
| this.#appCheck = initializeAppCheck(this.firebaseService.getFirebaseApp(), { | ||
| provider: new CustomProvider({ |
There was a problem hiding this comment.
Can you please add some docs to the docs folder on the appcheck implementation?
There was a problem hiding this comment.
Added reference: a872e40
|
|
||
| const solveChallenge = async ({ type, challengeDetails }: Params) => { | ||
| const solver = CHALLENGE_MAP[type]; | ||
| return solver(challengeDetails); |
There was a problem hiding this comment.
Should we do these calculations on a worker thread instead? If a user's computer is slow enough these challenges can slow down everything else as well.
There was a problem hiding this comment.
This is my only comment to the PR, other than that it looks good (I tested it too, following the instructions in the ticket description).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Testing
Screenshots:
Checklist for the author
Tick each of them when done or if not applicable.