Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link to Core Webs Halliday flow from Bridge #118

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Jan 7, 2025

Description

Changes

  • Adds a banner on the Bridge screen, which links to Core Web's Bridge flow with Halliday dialog opened (adds ?useHalliday=1 param)
    • When dismissed, the banner should not appear again
    • Togglable by feature flag: halliday-bridge-banner

Testing

  • ⚠️ The production version of Core Web does not have the Halliday integration yet.
  • ⚠️ The staging version of Core Web does not have the handling for useHalliday=1 query param yet (it's added by https://github.com/ava-labs/core-web/pull/104, so you can test that particular behavior with the version linked in that PR's comments)
  1. Enable feature flags if disabled
  2. Verify that Halliday banner appears on the Bridge screen
    2a. Verify that clicking the banner redirects you to core.app/bridge?useHalliday=1
    2b. Verify that dismissing the banner hides it for good (until a wallet reset happens)
  3. Verify that disabling feature flags turns both functionalities off (no banner on Bridge & clicking Buy does not add the ?useHalliday=1 param anymore)

Screenshots:

⚠️ Ignore the buy flow.

Screen.Recording.2025-01-07.at.14.30.38.mov

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

gergelylovas
gergelylovas previously approved these changes Jan 7, 2025
@meeh0w meeh0w changed the title feat: link to Core Webs Halliday flow from Buy and Bridge feat: link to Core Webs Halliday flow from Bridge Jan 7, 2025
Copy link
Contributor

@bferenc bferenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as described 👏

@meeh0w meeh0w merged commit 8cce5d2 into main Jan 7, 2025
6 checks passed
@meeh0w meeh0w deleted the feat/halliday-banners branch January 7, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants