fix: intermittent e2e failures #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
force-pushed
the
fix/e2e-intermittent-failrues
branch
from
8acf8b2 to
37201d6
Compare
vvava
approved these changes
Aug 6, 2024
bferenc
approved these changes
Aug 6, 2024
gergelylovas
reviewed
Aug 6, 2024
| @@ -326,7 +326,8 @@ export class NetworkService implements OnLock, OnStorageReady { | |||
| // At this point the chainlist from Glacier should already be available, | |||
| // as it is fetched when service worker starts (so before extension is unlocked). | |||
| // If it isn't available yet, we'll use the list cached in the storage. | |||
| const chainlist = await Promise.race([ | |||
|
|
|||
| const chainlist = await Promise.any([ | |||
There was a problem hiding this comment.
We should add a test for this to make sure what gets fixed here, stays fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
no ticket, favour to my beloved QAs 😄
Changes
Make it so that getting the cached list from storage throws error if nothing is found.
This allows us to use
Promise.any(...)instead ofPromise.race(...)- we'll essentially get the first promise that gives us a value.This is essential for E2E tests where QAs remove the storage-cached network list, since they are really big and they don't want it in their repos.
Testing
Checklist for the author