fix: do not require unlocking for wallet selector #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
commented
Feb 19, 2025
| @@ -175,7 +176,11 @@ export function WalletContextProvider({ children }: { children: any }) { | |||
| [request], | |||
| ); | |||
|
|
|||
| if (!isWalletLoading && isWalletLocked) { | |||
| // We do not require extension to be unlocked for wallet selection | |||
| const routeMatch = useRouteMatch('/approve/select-wallet'); | |||
There was a problem hiding this comment.
Maybe it would be better to have a separate provider for locked/unlocked state (like a LockProvider) that would know which routes can be shown without auth, but I wasn't sure if it's worth it since it's just one route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Testing
Screenshots:
Checklist for the author
Tick each of them when done or if not applicable.