Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve pasting p/x address in contact form #22

Merged
merged 4 commits into from
Aug 12, 2024
Merged

fix: improve pasting p/x address in contact form #22

merged 4 commits into from
Aug 12, 2024

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 6, 2024

Description

Description in: https://ava-labs.atlassian.net/browse/CP-8558

Changes

This implements the suggested solution in the linked issue by removing the X/P- address prefixes when pasting an address in to the new contact form

Testing

Confirm by following the Steps to Reproduce in the issue and ensure that X/P- chain addresses are sanitized when pasting in to the X/P- address field in the new contact form. Ensure there is no sanitization upon manual entry

Screenshots:

p-x-address-input-fix.mov

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@vvava vvava merged commit 452d190 into main Aug 12, 2024
4 of 5 checks passed
@vvava vvava deleted the fix/CP-8558 branch August 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants