Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add extension key to e2e ci workflow so snapshots work #23

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

ryanewood
Copy link
Contributor

@ryanewood ryanewood commented Aug 6, 2024

Description

The E2E smoke tests need to have the extension key added to the manifest file so that the extension ID is the expected ID after building. The local storage snapshots set at the beginning of tests need this to work properly (set testnet/mainnet, set active network etc).

NOTE: Needs EXTENSION_PUBLIC_KEY to be added as a secret to this repo for this to work. Please let me know if the secret already exists and is named something else.

Changes

Adds command in e2e CI flow to add extension public key to manifest file after building extension

Testing

This command currently works across all regression and smoke CI workflows in the test automation repo. Same command is being used here.

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

ryanml
ryanml previously approved these changes Aug 7, 2024
gergelylovas
gergelylovas previously approved these changes Aug 7, 2024
@ryanewood ryanewood requested review from meeh0w, bferenc and vvava August 9, 2024 14:15
@gergelylovas gergelylovas merged commit 7bbdbc6 into main Aug 9, 2024
5 checks passed
@gergelylovas gergelylovas deleted the fix-e2e-ci branch August 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants