-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add extension key to e2e ci workflow so snapshots work #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
previously approved these changes
Aug 7, 2024
gergelylovas
previously approved these changes
Aug 7, 2024
gergelylovas
approved these changes
Aug 9, 2024
ryanml
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The E2E smoke tests need to have the extension key added to the manifest file so that the extension ID is the expected ID after building. The local storage snapshots set at the beginning of tests need this to work properly (set testnet/mainnet, set active network etc).
✅
NOTE: NeedsEXTENSION_PUBLIC_KEY
to be added as a secret to this repo for this to work. Please let me know if the secret already exists and is named something else.Changes
Adds command in e2e CI flow to add extension public key to manifest file after building extension
Testing
This command currently works across all regression and smoke CI workflows in the test automation repo. Same command is being used here.
Checklist for the author
Tick each of them when done or if not applicable.