-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address onboarding UI deviations #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ryanml <[email protected]>
ryanml
commented
Aug 7, 2024
@@ -18,11 +18,12 @@ export function ExistingWalletButton({ | |||
width: '225px', | |||
height: '180px', | |||
borderRadius: 2, | |||
backgroundColor: 'grey.700', | |||
backgroundColor: 'rgba(88, 88, 91, 0.75)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using explicit values with rgba
to make sure the text is not transparent, only the background
vvava
approved these changes
Aug 8, 2024
bferenc
previously approved these changes
Aug 9, 2024
vvava
requested changes
Aug 12, 2024
src/pages/Onboarding/pages/Seedless/components/ExistingWalletOptions.tsx
Outdated
Show resolved
Hide resolved
vvava
previously approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job with changing the icon!
bferenc
approved these changes
Aug 12, 2024
vvava
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the onboarding UI design deviations described in: https://ava-labs.atlassian.net/browse/CP-8979
Testing
Verify the five items in the issue
Screenshots:
Checklist for the author
Tick each of them when done or if not applicable.