Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address onboarding UI deviations #24

Merged
merged 6 commits into from
Aug 13, 2024
Merged

fix: address onboarding UI deviations #24

merged 6 commits into from
Aug 13, 2024

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 7, 2024

Description

Fixes the onboarding UI design deviations described in: https://ava-labs.atlassian.net/browse/CP-8979

Testing

Verify the five items in the issue

Screenshots:

Screenshot 2024-08-06 at 7 20 10 PM

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@@ -18,11 +18,12 @@ export function ExistingWalletButton({
width: '225px',
height: '180px',
borderRadius: 2,
backgroundColor: 'grey.700',
backgroundColor: 'rgba(88, 88, 91, 0.75)',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using explicit values with rgba to make sure the text is not transparent, only the background

bferenc
bferenc previously approved these changes Aug 9, 2024
vvava
vvava previously approved these changes Aug 12, 2024
Copy link
Contributor

@vvava vvava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job with changing the icon!

@vvava vvava merged commit ce79553 into main Aug 13, 2024
5 checks passed
@vvava vvava deleted the fix/CP-8979 branch August 13, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants