Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add manage collectibles feature #25

Merged
merged 3 commits into from
Aug 13, 2024
Merged

feat: add manage collectibles feature #25

merged 3 commits into from
Aug 13, 2024

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 9, 2024

Description

Implements a feature to manage the display of a user's nft's per: https://ava-labs.atlassian.net/browse/CP-9039

Changes

  1. Added new view for managing collectibles
  2. Updated settings handlers to accommodate the new allowlist

Testing

Verify that the three AC's specified in the story work correctly

Screenshots:

Screenshot 2024-08-08 at 8 37 35 PM Screenshot 2024-08-08 at 8 37 22 PM

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@ryanml
Copy link
Contributor Author

ryanml commented Aug 9, 2024

I thought about just using the tokensVisibility structure in the SettingsState, as it could be used with some adjustments to the typing of the parameters the handlers receive, but I thought it made sense to have a separation of concerns here.

@@ -114,6 +115,16 @@ const disabledFeatures: Record<string, BlacklistConfig> = {
],
complexChecks: [],
},
ManageCollectibles: {
Copy link
Contributor Author

@ryanml ryanml Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to confirm what these should be

@bferenc bferenc merged commit 09373dc into main Aug 13, 2024
4 of 5 checks passed
@bferenc bferenc deleted the fix/CP-9039 branch August 13, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants