Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove eth as swappable token #5

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: remove eth as swappable token #5

merged 1 commit into from
Jul 29, 2024

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 29, 2024

Description

Issue is described here: https://ava-labs.atlassian.net/browse/CP-8409

Changes

Removed ETH as a swappable token, as well as provided a mechanism for doing so for other assets in the future if needed

Testing

  1. Ensure ETH is present as a selectable token during other flows, such as send
  2. Ensure ETH is not present as an option in Swaps

Screenshots:

Screenshot 2024-07-18 at 12 08 45 AM Screenshot 2024-07-18 at 12 10 20 AM

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@ryanml
Copy link
Contributor Author

ryanml commented Jul 29, 2024

This is the PR moved from the old repository. @meeh0w this includes your suggested change to avoid the hook rerunning

Copy link
Contributor

@vvava vvava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔂

@ryanml ryanml merged commit 85dbef4 into main Jul 29, 2024
4 of 5 checks passed
@ryanml ryanml deleted the fix/CP-8409 branch July 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants