Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: get btc fees via BitcoinModule #8

Merged
merged 7 commits into from
Aug 21, 2024
Merged

refactor: get btc fees via BitcoinModule #8

merged 7 commits into from
Aug 21, 2024

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Jul 31, 2024 •
edited by gergelylovas
Loading

Description

TODO

Changes

  • Fetches BTC network fees using the BitcoinModule

Testing

  • Verify the Bitcoin network fees against the production build (should be the same)

Screenshots

No visual changes

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w meeh0w added the DO NOT MERGE This PR is not meant to be merged in its current state label Jul 31, 2024
@meeh0w meeh0w force-pushed the refactor/btc-history branch from 122454a to dad3218 Compare July 31, 2024 13:21
@meeh0w meeh0w force-pushed the refactor/btc-fee-rate branch from ad6b32d to 4d4736c Compare July 31, 2024 13:21
vvava
vvava previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@vvava vvava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@meeh0w meeh0w force-pushed the refactor/btc-history branch from dad3218 to a335e12 Compare August 2, 2024 10:07
@meeh0w meeh0w force-pushed the refactor/btc-fee-rate branch from 4d4736c to 7bdd564 Compare August 2, 2024 10:24
@meeh0w meeh0w force-pushed the refactor/btc-fee-rate branch from 7bdd564 to 6083695 Compare August 2, 2024 14:16
@meeh0w meeh0w mentioned this pull request Aug 2, 2024
Merged
2 tasks
Base automatically changed from refactor/btc-history to main August 13, 2024 18:56
@gergelylovas gergelylovas dismissed vvava’s stale review August 13, 2024 18:56

The base branch was changed.

@gergelylovas gergelylovas removed the DO NOT MERGE This PR is not meant to be merged in its current state label Aug 13, 2024
bferenc
bferenc approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@bferenc bferenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and received the same fees as in the prod version 👍
image

@meeh0w meeh0w merged commit a5af551 into main Aug 21, 2024
4 of 5 checks passed
@meeh0w meeh0w deleted the refactor/btc-fee-rate branch August 21, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bferenc bferenc bferenc approved these changes

@gergelylovas gergelylovas gergelylovas approved these changes

@ryanml ryanml ryanml approved these changes

@vvava vvava vvava left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meeh0w @ryanml @gergelylovas @vvava @bferenc