Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-9743: prompt user to enable notification if disabled in settings #2203

Merged
merged 2 commits into from
Jan 28, 2025
Merged

CP-9743: prompt user to enable notification if disabled in settings #2203

merged 2 commits into from
Jan 28, 2025

Conversation

ruijialin-avalabs
Copy link
Contributor

@ruijialin-avalabs ruijialin-avalabs commented Jan 28, 2025 •
edited
Loading

Description

Ticket: CP-9743

  • if user has disabled system notifications, always prompt them to take them to system settings to enable it.
  • ff enable-notification-prompt can be turned off to skip prompting user if it becomes an issue.

Screenshots/Videos

Screen.Recording.2025-01-28.at.3.44.19.PM.mov

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@ruijialin-avalabs ruijialin-avalabs merged commit e75fa1a into main Jan 28, 2025
4 checks passed
@ruijialin-avalabs ruijialin-avalabs deleted the cp-9743 branch January 28, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atn4z7 atn4z7 atn4z7 approved these changes

@neven-s neven-s Awaiting requested review from neven-s neven-s is a code owner

@onghwan onghwan Awaiting requested review from onghwan onghwan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruijialin-avalabs @atn4z7