CP-9702: Account Header + Animation #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onghwan
requested review from
neven-s,
atn4z7 and
ruijialin-avalabs
as code owners
packages/k2-alpine/src/components/PriceChangeIndicator/PriceChangeIndicator.tsx
Outdated
Show resolved
Hide resolved
packages/core-mobile/app/new/routes/(signedIn)/(tabs)/portfolio/index.tsx
Show resolved
Hide resolved
packages/core-mobile/app/new/routes/(signedIn)/(tabs)/portfolio/index.tsx
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Feb 6, 2025
packages/core-mobile/app/new/routes/(signedIn)/(tabs)/portfolio/index.tsx
Show resolved
Hide resolved
atn4z7
reviewed
Feb 6, 2025
| ) | ||
| } | ||
|
|
||
| const ERROR_COLOR = '#F5643B' |
There was a problem hiding this comment.
have you asked design about this color? hardcoding this here will affect dark/light modes
There was a problem hiding this comment.
Figma was a bit outdated. I’ve replaced all the colors with the ones from the palette.
atn4z7
reviewed
Feb 6, 2025
packages/k2-alpine/src/components/PriceChangeIndicator/PriceChangeIndicator.tsx
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Feb 6, 2025
packages/k2-alpine/src/components/PriceChangeIndicator/PriceChangeIndicator.tsx
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Feb 6, 2025
packages/k2-alpine/src/components/PriceChangeIndicator/PriceChangeIndicator.tsx
Outdated
Show resolved
Hide resolved
atn4z7
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9702
BalanceHeaderandNavigationTitleHeader) and their stories.PriceChangeIndicator+ stories.useAnimatedNavigationHeaderto animate the transition between headers with scroll.Screenshots/Videos
Screen_recording_20250205_094224.webm
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-04.at.17.03.35.mp4