CP-9840: Fix unable to bridge ETH to C-Chain #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atn4z7
requested review from
neven-s,
ruijialin-avalabs and
onghwan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9840
problem: we weren't passing
valueto theeth_sendTransactionwrap transaction. thus, nothing were deposited.solution: make sure we pass value to tx params when it is present (thanks @meeh0w for pointing this out)
also bumping the vm module version from
1.2.0to1.2.1since there was a simulation bug https://github.com/ava-labs/vm-modules/pull/228Testing
Please retest bridging cases where a wrap transaction is needed
Checklist
Please check all that apply (if applicable)