Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated apis #711

Merged
merged 14 commits into from
Jan 21, 2025
Merged

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Dec 19, 2024

Why this should be merged

Removes unnecessary, unused, deprecated code and APIs

How this works

This pull request involves significant changes to the codebase, primarily focusing on removing the multi-coin balance feature and simplifying the export transaction logic. Below are the most important changes grouped by theme:

Removal of Multi-Coin Balance Feature:

Simplification of Export Transaction Logic:

Test Updates:

Code Simplification:

How this was tested

Need to bootstrap testnet/mainnet since it includes a change to genesis

Need to be documented?

Should remove docs containing these APIs

Need to update RELEASES.md?

Yes

@ceyonur ceyonur changed the base branch from master to move-atomic-state December 30, 2024 07:28
plugin/evm/service.go Outdated Show resolved Hide resolved
core/genesis.go Show resolved Hide resolved
@ceyonur ceyonur marked this pull request as ready for review January 7, 2025 13:01
@ceyonur ceyonur requested review from darioush and a team as code owners January 7, 2025 13:01
@ceyonur ceyonur self-assigned this Jan 7, 2025
Base automatically changed from move-atomic-state to seperate-atomic-pkg-base January 7, 2025 13:45
RELEASES.md Outdated Show resolved Hide resolved
plugin/evm/atomic/export_tx.go Outdated Show resolved Hide resolved
plugin/evm/vm_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@darioush darioush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits, also let's try to figure out if it's in use before merging.

plugin/evm/atomic/export_tx.go Outdated Show resolved Hide resolved
plugin/evm/atomic/export_tx.go Outdated Show resolved Hide resolved
plugin/evm/vm_test.go Outdated Show resolved Hide resolved
ceyonur and others added 3 commits January 7, 2025 19:00
Co-authored-by: Quentin McGaw <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
plugin/evm/atomic/export_tx.go Show resolved Hide resolved
@ceyonur ceyonur merged commit 709d51c into seperate-atomic-pkg-base Jan 21, 2025
6 checks passed
@ceyonur ceyonur deleted the remove-deprecated-apis branch January 21, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants