-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated apis #711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
commented
Dec 30, 2024
ceyonur
commented
Jan 7, 2025
qdm12
approved these changes
Jan 7, 2025
darioush
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple nits, also let's try to figure out if it's in use before merging.
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
darioush
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes unnecessary, unused, deprecated code and APIs
How this works
This pull request involves significant changes to the codebase, primarily focusing on removing the multi-coin balance feature and simplifying the export transaction logic. Below are the most important changes grouped by theme:
Removal of Multi-Coin Balance Feature:
core/genesis.go
: Removed handling ofMCBalance
in thetoBlock
function.core/state/dump.go
: Removed theIsMultiCoin
field from theDumpAccount
struct and related functions. [1] [2] [3]core/types/account.go
: Removed theGenesisMultiCoinBalance
type andMCBalance
field from theGenesisAccount
struct.core/types/gen_genesis_account.go
: Removed theMCBalance
field from theGenesisAccount
struct in bothMarshalJSON
andUnmarshalJSON
methods. [1] [2] [3] [4]Simplification of Export Transaction Logic:
plugin/evm/atomic/export_tx.go
: Removed theassetID
parameter and related logic from theNewExportTx
andGetSpendableFunds
functions, usingctx.AVAXAssetID
directly. [1] [2] [3] [4] [5] [6]plugin/evm/client/client.go
: Removed theExportArgs
struct and updated theExport
function to useExportAVAXArgs
directly. [1] [2]Test Updates:
core/state/state_test.go
: RemovedisMultiCoin
field from test cases in theTestDump
andTestIterativeDump
functions. [1] [2] [3] [4]plugin/evm/export_tx_test.go
: Updated test cases to reflect the changes in theNewExportTx
function. [1] [2]Code Simplification:
internal/ethapi/api.go
: Simplified variable declarations inInspect
andResend
functions. [1] [2]How this was tested
Need to bootstrap testnet/mainnet since it includes a change to genesis
Need to be documented?
Should remove docs containing these APIs
Need to update RELEASES.md?
Yes