Timelock example #1068
Open
Timelock example #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for context injections #1076 to land before writing actual tests |
iFrostizz
force-pushed
the
multisig_example
branch
from
eb5cbb3 to
9c2c3ab
Compare
iFrostizz
force-pushed
the
multisig_example
branch
3 times, most recently
from
1eaa311 to
aa51f3e
Compare
iFrostizz
force-pushed
the
timelock_example
branch
from
bdfa028 to
e99cc03
Compare
iFrostizz
requested review from
dboehm-avalabs,
richardpringle and
patrick-ogrady
as code owners
| @@ -0,0 +1,313 @@ | |||
| use borsh::{BorshDeserialize, BorshSerialize}; | |||
| #[cfg(not(feature = "bindings"))] | |||
| use wasmlanche_sdk::Context; | |||
There was a problem hiding this comment.
🤔 What if we just made this an enum?
Not for this PR, but just a thought
There was a problem hiding this comment.
Can you please explain what could be an enum (probably selected the wrong piece of code?)
| .run_step(&Step { | ||
| endpoint: Endpoint::Execute, | ||
| method: "schedule".to_string(), | ||
| max_units: u64::MAX, |
richardpringle
requested changes
Jul 8, 2024
iFrostizz
force-pushed
the
multisig_example
branch
from
293f691 to
762a248
Compare
iFrostizz
force-pushed
the
timelock_example
branch
from
17aef7e to
34b8011
Compare
iFrostizz
force-pushed
the
timelock_example
branch
from
34b8011 to
7fa89ae
Compare
|
This PR should be merged after the Multisig #1047 |
iFrostizz
force-pushed
the
multisig_example
branch
from
36b8f2c to
44c962b
Compare
iFrostizz
force-pushed
the
multisig_example
branch
from
c5dd019 to
000bce5
Compare
iFrostizz
force-pushed
the
multisig_example
branch
from
be21b8f to
6a07ba0
Compare
iFrostizz
force-pushed
the
timelock_example
branch
3 times, most recently
from
206be8a to
c967dfd
Compare
iFrostizz
force-pushed
the
timelock_example
branch
from
c967dfd to
b9dcce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is currently based on both https://github.com/ava-labs/hypersdk/tree/multisig_example for arbitrary return function call types and https://github.com/ava-labs/hypersdk/tree/add_timestamp to have access to the timestamp in the context