Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luka/gen hash fix #345

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Luka/gen hash fix #345

merged 4 commits into from
Nov 15, 2023

Conversation

luka-ethernal
Copy link
Collaborator

  • Fix genesis_hash storing and checking (also system_version and spec_version)
  • Add more useful logs in case finality verification fails

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (f5d4460) 36.18% compared to head (ed826c6) 36.14%.

Files Patch % Lines
src/network/rpc/event_loop.rs 0.00% 14 Missing ⚠️
src/network/rpc.rs 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   36.18%   36.14%   -0.05%     
==========================================
  Files          29       29              
  Lines       12793    12808      +15     
==========================================
  Hits         4629     4629              
- Misses       8164     8179      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luka-ethernal luka-ethernal merged commit 1b1c6e7 into main Nov 15, 2023
@luka-ethernal luka-ethernal deleted the luka/gen_hash-fix branch November 15, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants