Remove disable proof verification configuration #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `disable_proof_verification` description is misleading and only use of this parameter is to disable proof verification during the confidence check, we can remove this parameter.
aterentic-ethernal
requested review from
kroos47,
0xSasaPrsic,
momoshell,
sh3ll3x3c and
luka-ethernal
luka-ethernal
approved these changes
Nov 22, 2023
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 35.93% 35.94%
=======================================
Files 29 29
Lines 12919 12901 -18
=======================================
- Hits 4643 4637 -6
+ Misses 8276 8264 -12 ☔ View full report in Codecov by Sentry. |
kroos47
approved these changes
Nov 22, 2023
|
But what do we use instead to fetch cells without verifying proof? |
sh3ll3x3c
approved these changes
Nov 22, 2023
This covers only random sampling cells, which is insignificant. |
momoshell
approved these changes
Nov 22, 2023
aterentic-ethernal
deleted the
remove-disable-proof-verification-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
disable_proof_verificationdescription is misleading and onlyuse of this parameter is to disable proof verification during the
confidence check, we can remove this parameter.