Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed wrong put success rate metric calculation #407

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fixed wrong put success rate metric calculation #407

merged 1 commit into from
Jan 9, 2024

Conversation

sh3ll3x3c
Copy link
Member

No description provided.

vbhattaccmu
vbhattaccmu reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@vbhattaccmu vbhattaccmu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can block.total_count achieve a value equal to zero? In that case we might need to define a success_rate value.

@sh3ll3x3c
Copy link
Member Author

sh3ll3x3c commented Jan 9, 2024 •
edited
Loading

Can block.total_count achieve a value equal to zero? In that case we might need to define a success_rate value.

@vbhattaccmu No, no, total count is >0 (for now) because the matrix can't be of 0 size. Min is 4 iirc

@sh3ll3x3c sh3ll3x3c merged commit 1ac15d0 into main Jan 9, 2024
1 check passed
@sh3ll3x3c sh3ll3x3c deleted the error-rate-counter-fix branch January 9, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbhattaccmu vbhattaccmu vbhattaccmu approved these changes

@momoshell momoshell Awaiting requested review from momoshell

@aterentic-ethernal aterentic-ethernal Awaiting requested review from aterentic-ethernal

@luka-ethernal luka-ethernal Awaiting requested review from luka-ethernal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh3ll3x3c @vbhattaccmu