Move p2p diagnostic APIs to its own mod #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbhattaccmu
requested review from
aterentic-ethernal,
momoshell and
sh3ll3x3c
momoshell
reviewed
Nov 8, 2024
core/src/api/diagnostics/mod.rs
Outdated
| fn p2p_peer_multiaddr_route( | ||
| p2p_client: Client, | ||
| ) -> impl Filter<Extract = (impl Reply,), Error = Rejection> + Clone { | ||
| warp::path!("p2p" / "peers" / "get-multiaddress") |
There was a problem hiding this comment.
method is post, but the actual route is "get-multiaddress"?
There was a problem hiding this comment.
renamed it as GET method
momoshell
approved these changes
Nov 8, 2024
…oject/avail-light into refactor/diagnostics-api
sh3ll3x3c
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.