add config masking headers value

avew · Jun 13, 2023 · 2112be4 · 2112be4
1 parent 0a7986c
commit 2112be4
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 8 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>avew.github.io</groupId>
     <artifactId>retrofit-mask</artifactId>
-    <version>1.0.6</version>
+    <version>1.0.7</version>
     <packaging>jar</packaging>
     <description>Custom retrofit with masking log</description>
 

diff --git a/src/main/java/io/github/avew/CustomHttpConfig.java b/src/main/java/io/github/avew/CustomHttpConfig.java
@@ -5,6 +5,7 @@
 import lombok.Data;
 import lombok.NoArgsConstructor;
 
+import java.util.ArrayList;
 import java.util.List;
 
 @Data
@@ -31,6 +32,9 @@ public class CustomHttpConfig {
     private boolean masking = true;
     @Builder.Default
     private boolean retryConnectionFailure = false;
+    @Builder.Default
+    private List<String> excludeHeaders = new ArrayList<>();
+
 
     @Override
     public String toString() {

diff --git a/src/main/java/io/github/avew/VewHttp.java b/src/main/java/io/github/avew/VewHttp.java
@@ -58,10 +58,10 @@ public Retrofit.Builder builder(Consumer<OkHttpClient.Builder> configureClient)
             httpClient.retryOnConnectionFailure(config.isRetryConnectionFailure());
             httpClient.addInterceptor(chain -> {
                 Request original = chain.request();
-                Request request = original.newBuilder()
-                        .header("User-Agent", config.getAgent())
-                        .build();
-                return chain.proceed(request);
+                Request.Builder request = original.newBuilder();
+                request.header("User-Agent", config.getAgent());
+                if (config.isRetryConnectionFailure()) request.header("Connection", "close");
+                return chain.proceed(request.build());
             });
             if (config.isMasking()) {
                 httpClient.addNetworkInterceptor(customNetworkInterceptors());
@@ -184,8 +184,11 @@ private CustomizableHttpLoggingInterceptor customNetworkInterceptors() {
                 },
                 debug,
                 debug);
-        logging.redactHeader("Authorization");
-        logging.redactHeader("Cookie");
+        if (config.getExcludeHeaders().isEmpty()) {
+            logging.redactHeader("Authorization");
+            logging.redactHeader("Cookie");
+        } else config.getExcludeHeaders().forEach(logging::redactHeader);
+
         return logging;
     }
 

diff --git a/src/test/java/io/github/avew/OkHttpTest.java b/src/test/java/io/github/avew/OkHttpTest.java
@@ -42,9 +42,11 @@ public void init() {
         CustomHttpConfig customHttpConfig = CustomHttpConfig.builder()
                 .url("https://reqres.in")
                 .agent("OkHttp/4.1.0")
-                .masking(false)
+                .masking(true)
+                .excludeHeaders(Arrays.asList("X-Api-Key","User-Agent","Host"))
                 .build();
         log.debug("CONFIG {}", customHttpConfig.getCustomTimeout());
+        log.debug("CONFIG {}", customHttpConfig.getExcludeHeaders());
 
         ObjectMapper mapper = new ObjectMapper();
         mapper.writerWithDefaultPrettyPrinter();