Java: Allow cluster wide scan with not fully covered cluster #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: avifenesh <[email protected]>
Signed-off-by: avifenesh <[email protected]>
avifenesh
force-pushed
the
Node@allow-ucslots-Cscan
branch
from
9c6b040 to
a42b9ec
Compare
…rClient Signed-off-by: avifenesh <[email protected]>
… option Signed-off-by: avifenesh <[email protected]>
avifenesh
force-pushed
the
Node@allow-ucslots-Cscan
branch
from
a42b9ec to
2dec9d0
Compare
|
I only review Java portion and the changes look fine. Please resolve the conflicts. |
Signed-off-by: avifenesh <[email protected]>
Signed-off-by: James Xin <[email protected]>
jamesx-improving
force-pushed
the
java/jamesx-allow-ucslots-scan
branch
from
978750a to
d1a9be0
Compare
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
avifenesh
force-pushed
the
Node@allow-ucslots-Cscan
branch
6 times, most recently
from
57c2c6c to
6518cf3
Compare
|
@jamesx-improving, Avi has merged his changes. Please rebase your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a FOR REVIEW ONLY PR with the Java part for issue: valkey-io#2436
This will eventually merge to https://github.com/valkey-io/valkey-glide/tree/release-1.2