Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assertPossibleRetainCycle more generic #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ailinykh
Copy link

@ailinykh ailinykh commented Mar 15, 2024

The project has an error at build time because of an implicit UIKit import in ModalDismissalRetainCycleAssertion
This PR makes interface ModalDismissalRetainCycleAssertion more generic, so it does not coupled with UIKit any more
Screenshot 2024-03-15 at 09 46 23

@Usipov
Copy link
Collaborator

Usipov commented Apr 1, 2024

Привет) сори, не видел ПР. На неделе волью импорт. А изменение в ассертах может быть откачу, тк готовится ветка с большим диффом, и лучше снизить число конфликтов (а текущий дифф просто сахар)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants