Fix goroutine leaking #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. fixed problems for sql and sqlx
2. fixed data race with sqlmock
2. Added Closed for transaction to catch when transaction really closed. 3. Fix gorm goroutine leak
2. Fixed linters error
maranqz
force-pushed
the
v1-fix-goroutine-leak
branch
from
f2121c3
to
bfcce81
Compare
2. Fixed linters error
maranqz
force-pushed
the
v1-fix-goroutine-leak
branch
from
970c136
to
0b5e447
Compare
maranqz
force-pushed
the
v1-fix-goroutine-leak
branch
from
8e08417
to
2fdd8e6
Compare
maranqz
commented
Feb 4, 2024
maranqz
commented
Feb 4, 2024
maranqz
force-pushed
the
v1-fix-goroutine-leak
branch
from
19a2bed
to
ab988b0
Compare
Foxprodev
reviewed
Feb 14, 2024
| @@ -77,7 +88,7 @@ func (t *Transaction) Commit(ctx context.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| defer t.deactivate() | |||
| defer t.isClosed.Close() | |||
There was a problem hiding this comment.
А что будет, если будет ошибка при релизе сейвпоинта?
There was a problem hiding this comment.
BEGIN;
SAVEPOINT SP1;
SAVEPOINT SP2;
RELEASE SAVEPOINT SP2; -- return err
ROLLBACK TO SAVEPOINT SP1; -- т.к. будет вверх возвращаться err
-- Если err перехватят, то RELEASE SAVEPOINT SP1 в случае если ошибка и не закрылся коннект.
ROLLBACK; -- т.к. будет вверх возвращаться err и не закрылся коннект
-- Если err перехватят, то успешный COMMIT и не закрылся коннект.
Чуть более правильным был бы подход, когда мы создаем отдельный объект на вложенную транзакцию, однако я не готов делать это в текущем PR, но для V2 можно сделать.
There was a problem hiding this comment.
Вот я как раз про закрытый коннект, сейчас кажется не отслеживается, если коннект закроется.
Так-то ПР хуже не делает точно, просто набрасываю какие еще есть кейсы, в которых может остаться горутина
Foxprodev
approved these changes
Feb 15, 2024
Foxprodev
approved these changes
Feb 15, 2024
Foxprodev
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A goroutine leak occurs when the TRM is used in crons or worker, and the main context lives for a long time.
To solve this problem before PR, you can set setttings.Cancelable equals true.