You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Hardcoded Data The mock data for form definitions contains excessively long and hardcoded strings which might not be scalable or easy to manage. Consider simplifying these or using more manageable data structures.
Error Handling The error handling in the onEvent function could be improved by ensuring that all potential error paths are adequately addressed and that the error messages provided to the user are clear and informative.
Complex Logic The logic within the onEvent function is quite complex and involves multiple levels of mapping and data transformation. This could benefit from further decomposition into smaller, more manageable functions.
Add null check for the response from healthieSdk.client.mutation to prevent potential runtime errors
Consider handling the case where healthieSdk.client.mutation might return null or undefined before accessing properties on res.createFormAnswerGroup.form_answer_group.id to prevent runtime errors.
-if (isEmpty(res?.createFormAnswerGroup?.form_answer_group?.id))+if (!res || isEmpty(res?.createFormAnswerGroup?.form_answer_group?.id))
throw new HealthieFormResponseNotCreated(res)
Suggestion importance[1-10]: 8
Why: The suggestion correctly identifies a potential runtime error if healthieSdk.client.mutation returns null or undefined. Adding a null check enhances the robustness of the code by preventing possible crashes when accessing properties on a potentially null object.
8
Maintainability
Remove the deprecated and non-functional updateAddendum mutation
To avoid confusion and maintain clean code, remove the deprecated updateAddendum mutation if it no longer performs any function.
-/**- * @deprecated Deprecated. Does nothing- * THIS MUTATION DOES NOTHING, AND SHOULD NOT BE USED.- */-updateAddendum: (updateAddendumPayload | null)+// This mutation has been removed due to deprecation and no operational functionality.
Suggestion importance[1-10]: 7
Why: Removing a non-functional mutation improves code maintainability and prevents potential confusion. However, the suggestion does not provide the improved code, which slightly reduces its effectiveness.
7
Remove the deprecated clientMutationId field from LockPayload
Refactor the LockPayload to remove the deprecated clientMutationId field if it is no longer required, to streamline the interface.
-/**- * @deprecated DO NOT USE- * DO NOT USE- */-clientMutationId: (Scalars['String'] | null)+// The clientMutationId has been removed to simplify the payload structure.
Suggestion importance[1-10]: 7
Why: The suggestion to remove an unused field helps streamline the interface, enhancing maintainability. However, the suggestion lacks the improved code, which limits its completeness.
7
Best practice
Mark the insurance_billing_enabled field as deprecated in the code and documentation
Ensure that the insurance_billing_enabled field in AppointmentTypeCptCodeType is properly deprecated in the GraphQL schema to avoid future usage, as it's now replaced by appointmentType's insurance_billing_enabled.
-/**- * @deprecated Use appointmentType's insurance_billing_enabled instead- * DEPRECATED. Use appointmentType's insurance_billing_enabled instead- */+// This field is deprecated and should not be used in new code.+// Refer to the `insurance_billing_enabled` in the `AppointmentType` for enabling insurance billing.
insurance_billing_enabled: (Scalars['Boolean'] | null)
Suggestion importance[1-10]: 6
Why: The suggestion provides a clearer deprecation notice, which can help developers avoid using outdated fields. It aligns with best practices for maintaining code clarity and preventing future usage.
6
Enhancement
Improve the descriptiveness of the comment for the Action type
Consider adding a more descriptive comment for the Action type to explain the context in which these actions are used, enhancing code readability and maintainability.
-/** Enum for `FormAnswerGroupAuditEvent#action` */+/** Enum for `FormAnswerGroupAuditEvent#action` describing the possible states of a form in response to user interactions */
export type Action = 'LOCKED' | 'UNLOCKED' | 'SIGNED' | 'ADDENDUM_CREATED'
Suggestion importance[1-10]: 5
Why: The suggestion enhances the comment's clarity, providing better context for the Action type. While it improves readability, the impact is moderate as it doesn't affect functionality.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
enhancement
PR Type
Enhancement, Tests
Description
pushFormResponsesToHealthieandpushFormResponseToHealthieactions.Changes walkthrough 📝
2 files
schema.ts
Extend schema with form answer group and eligibility check typesextensions/healthie/lib/sdk/genql/generated/schema.ts
eligibility checks.
connections.
implementations.
pushFormResponsesToHealthie.ts
Implement pushFormResponsesToHealthie actionextensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/pushFormResponsesToHealthie.ts
5 files
formDefinitionResponse.ts
Add mock data for form definition responsesextensions/healthie/actions/dataExchange/pushFormResponseToHealthie/mocks/formDefinitionResponse.ts
pushFormResponsesToHealthie.test.ts
Add tests for pushFormResponsesToHealthie actionextensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/pushFormResponsesToHealthie.test.ts
getAllFormsInCurrentStep.test.ts
Add tests for getAllFormsInCurrentStep functionsrc/lib/awell/getAllFormsInCurrentStep/getAllFormsInCurrentStep.test.ts
pushFormResponseToHealthie.test.ts
Add tests for pushFormResponseToHealthie actionextensions/healthie/actions/dataExchange/pushFormResponseToHealthie/pushFormResponseToHealthie.test.ts
formResponseResponse.ts
Add mock data for form response responsesextensions/healthie/actions/dataExchange/pushFormResponseToHealthie/mocks/formResponseResponse.ts
36 files
types.ts
...extensions/healthie/lib/sdk/genql/generated/types.ts
...
getSubActivityLogs.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/logs/getSubActivityLogs/getSubActivityLogs.ts
...
getAllFormsInCurrentStep.ts
...src/lib/awell/getAllFormsInCurrentStep/getAllFormsInCurrentStep.ts
...
getSubActivityLogs.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/logs/getSubActivityLogs/getSubActivityLogs.ts
...
pathwayActivitiesResponse.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/mocks/pathwayActivitiesResponse.ts
...
pathwayActivitiesResponse.ts
...src/lib/awell/getAllFormsInCurrentStep/testdata/pathwayActivitiesResponse.ts
...
pathwayActivitiesResponse.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/mocks/pathwayActivitiesResponse.ts
...
getSubActivityLogs.test.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/logs/getSubActivityLogs/getSubActivityLogs.test.ts
...
getSubActivityLogs.test.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/logs/getSubActivityLogs/getSubActivityLogs.test.ts
...
pushFormResponseToHealthie.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/pushFormResponseToHealthie.ts
...
formDefinitionResponse.ts
...src/lib/awell/getAllFormsInCurrentStep/testdata/formDefinitionResponse.ts
...
formDefinitionResponse.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/mocks/formDefinitionResponse.ts
...
fields.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/config/fields.ts
...
fields.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/config/fields.ts
...
errors.ts
...extensions/healthie/actions/dataExchange/shared/errors.ts
...
formResponseResponse.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/mocks/formResponseResponse.ts
...
index.ts
...extensions/healthie/actions/index.ts
...
formResponseResponse.ts
...src/lib/awell/getAllFormsInCurrentStep/testdata/formResponseResponse.ts
...
datapoints.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/config/datapoints.ts
...
datapoints.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/config/datapoints.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/mocks/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/mocks/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/config/index.ts
...
index.ts
...src/lib/awell/getAllFormsInCurrentStep/testdata/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/config/index.ts
...
index.ts
...src/lib/awell/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/logs/getSubActivityLogs/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponseToHealthie/logs/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/logs/getSubActivityLogs/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/pushFormResponsesToHealthie/logs/index.ts
...
index.ts
...src/lib/awell/getAllFormsInCurrentStep/index.ts
...
index.ts
...extensions/healthie/actions/dataExchange/shared/index.ts
...
schema.graphql
...extensions/healthie/lib/sdk/genql/generated/schema.graphql
...