Skip to content

Commit

Permalink
Merge pull request #8067 from easydigitaldownloads/issue/7722
Browse files Browse the repository at this point in the history
Update Chosen script/styles (#7722)
  • Loading branch information
ashleyfae authored Sep 3, 2020
2 parents 4a9b9be + e6ac36b commit d05e73a
Show file tree
Hide file tree
Showing 11 changed files with 427 additions and 262 deletions.
328 changes: 185 additions & 143 deletions assets/css/chosen.css

Large diffs are not rendered by default.

13 changes: 5 additions & 8 deletions assets/css/chosen.min.css

Large diffs are not rendered by default.

318 changes: 226 additions & 92 deletions assets/css/edd-admin-chosen.css

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions assets/css/edd-admin.css
Original file line number Diff line number Diff line change
Expand Up @@ -1048,6 +1048,7 @@ textarea[name="edd-note"] {

#edd-add-discount input[type="text"].edd_datepicker,
#edd-edit-discount input[type="text"].edd_datepicker {
display: inline-block;
width: 183px;
vertical-align: middle;
}
Expand All @@ -1064,6 +1065,7 @@ textarea[name="edd-note"] {
.edd-amount-type-wrapper select {
border-top-left-radius: 0;
border-bottom-left-radius: 0;
width: auto !important;
}

.edd-amount-type-wrapper #edd-amount {
Expand Down
3 changes: 3 additions & 0 deletions assets/js/vendor/chosen.jquery.min.js

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions assets/js/vendor/jquery.chosen.min.js

This file was deleted.

2 changes: 1 addition & 1 deletion includes/scripts.php
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ function edd_register_admin_scripts() {
$admin_deps = array( 'jquery', 'jquery-form', 'underscore' );

// Register scripts
wp_register_script( 'jquery-chosen', $js_dir . 'vendor/jquery.chosen.min.js', array( 'jquery' ), $version );
wp_register_script( 'jquery-chosen', $js_dir . 'vendor/chosen.jquery.min.js', array( 'jquery' ), $version );
wp_register_script( 'edd-jquery-flot', $js_dir . 'vendor/jquery.flot.min.js', array( 'jquery' ), $version );
wp_register_script( 'edd-moment-js', $js_dir . 'vendor/moment.min.js', array(), $version );
wp_register_script( 'edd-chart-js', $js_dir . 'vendor/chartjs.min.js', array( 'edd-moment-js' ), $version );
Expand Down
13 changes: 4 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"main": "webpack.config.js",
"dependencies": {
"chart.js": "2.7.2",
"chosen-js": "1.8.7",
"flot": "0.8.0-alpha",
"jquery-creditcardvalidator": "1.0.0",
"jquery-validation": "1.17.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/tests-easy-digital-downloads.php
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ public function _test_includes_assets_dp() {
array( EDD_PLUGIN_DIR . 'assets/js/edd-admin.js' ),
array( EDD_PLUGIN_DIR . 'assets/js/edd-ajax.js' ),
array( EDD_PLUGIN_DIR . 'assets/js/edd-checkout-global.js' ),
array( EDD_PLUGIN_DIR . 'assets/js/vendor/jquery.chosen.min.js' ),
array( EDD_PLUGIN_DIR . 'assets/js/vendor/chosen.jquery.min.js' ),
array( EDD_PLUGIN_DIR . 'assets/js/vendor/jquery.creditcardvalidator.min.js' ),
array( EDD_PLUGIN_DIR . 'assets/js/vendor/jquery.flot.min.js' ),

Expand Down
4 changes: 0 additions & 4 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,6 @@ const config = {
// Copy vendor files to ensure 3rd party plugins relying on a script
// handle to exist continue to be enqueued.
new CopyWebpackPlugin( [
{
from: './node_modules/chosen-js/chosen.jquery.min.js',
to: 'assets/js/vendor/jquery.chosen.min.js',
},
{
from: './node_modules/chart.js/dist/Chart.min.js',
to: 'assets/js/vendor/chartjs.min.js',
Expand Down

0 comments on commit d05e73a

Please sign in to comment.