-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "chosen" script with a more accessible option #7722
Comments
Noting that @robincornett opened this issue as a place to discuss alternatives/replacements for Chosen and to keep #7583 as a tracking issue for removing existing unneeded usage. |
Is Select2 an option? It seems to still be maintained. |
selectWoo is a select2 fork with accessibility related improvements and fixes so is probably a better option. |
I find it interesting that they chose to fork instead of contribute upstream. Maybe the Select2 team isn’t open to their suggestions. |
I spent last night forking Chosen, here: https://github.com/JJJ/chosen
Please consider giving my fork a try. It is drop-in replacement for what is in EDD already, and I'd love some help getting the tests to pass 🤗
I chose(ha!) to fork Chosen because it was tagged as deprecated and unmaintained by the folks at Harvest. It sat for a few years with tons of comments and PRS, but nobody helping them. |
Pulled from Sugar Calendar; note that .chosen-container-active.chosen-dropup styles still need to be handled. #7722
I'm not sure we should close this out completely until Chosen adds mobile support: JJJ/chosen#33 Currently searching for Downloads (or anything dynamic) does not work on mobile. |
Would it be worth opening a new issue, @spencerfinnell? I saw that John updated Chosen to 2.2.0 and what we've put into EDD 3.0 is 2.1.0, so an update would be needed anyway. Also, based on your comments there, this is a current issue with 2.9.x, yes? |
@robincornett Sure -- probably a good idea to track it separately. |
Enhancement Request
Justification or use case
Any select option using Chosen is currently not accessible to keyboard or screen reader users.
The text was updated successfully, but these errors were encountered: