feat(storage): emit response metadata in applicable error throw sites #14237
+72
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
requested review from
cshfang,
HuiSF,
ashika112 and
a team
as code owners
HuiSF
reviewed
Feb 22, 2025
Comment on lines
+90
to
+91
| // error is always set when statusCode >= 300 | ||
| throw buildStorageServiceError((await parseXmlError(response))!); |
There was a problem hiding this comment.
quick nit: this callsite requires consumer to know the implementation details of parseXmlError function to know when to safely use !. Would that make sense to just move the if (response.statusCode < 300) logic out from the parseXmlError and change it to parse2xxXmlError?
There was a problem hiding this comment.
This maybe possible but requires some cross-category interface changes. The ErrorParser interface implemented by parseXmlError returns optional parsed error. That's why I added the casting. I can follow-up on this other PR.😃
HuiSF
approved these changes
Feb 24, 2025
ashika112
approved these changes
Feb 24, 2025
AllanZhengYP
merged commit 9a3346e
into
aws-amplify:feat/monitoring-instrument/main
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
metadatatoStorageError, and make sure all the error thrown caused by erroneous responses includesmetadata.recoverySuggestionfrom 404 errorIssue #, if available
Description of how you validated changes
Unit test
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.