Feature/improve visual notebook #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding requirements.txt; there are different images to build here, and for Visual notebook you also need Tensorflow; but TF + OpenCV makes the image massive; hence the difference between cpu and cpu-tf images. For the default image it needs to be either TF+OpenCV or neither... |
|
removed open cv from requirements.txt and added opencv and tensorflow to the visual analysis notebook specifically to address the feedback @larsll |
larsll
requested changes
Apr 1, 2024
|
Ready for re-review @larsll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to use visual analysis from S3 or use the existing log location
Added cv to requirements so it gets installed
Choosing S3 bucket and which models you want to download results in them being copied locally
Action space probability: -
Moving view models to len(iterations) ensures all models are loaded: -
Ensuring they all get used for the heatmaps: -
