Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix example #17

Merged
merged 1 commit into from
Aug 30, 2023
Merged

docs: Fix example #17

merged 1 commit into from
Aug 30, 2023

Conversation

Almenon
Copy link
Contributor

@Almenon Almenon commented Aug 23, 2023

Tested and working. This fixes the below error with the previous example:

│ Error: creating IAM Policy (foo-20230823192221893600000002): MalformedPolicyDocument: Syntax errors in policy.
│ 	status code: 400, request id: 6448aac6-961f-4fe0-9b72-f37dfd22d78c
│ 
│   with module.foo.module.eks_blueprints_addon.aws_iam_policy.this[0],
│   on .terraform/modules/foo.eks_blueprints_addon/main.tf line 237, in resource "aws_iam_policy" "this":
│  237: resource "aws_iam_policy" "this" {
│

What does this PR do?

Sets create_policy to false, so the module doesn't try to create a policy when the user is trying to pass in a existing policy.

Motivation

Test Results

Additional Notes

@Almenon
fix example
13d0699 
Tested and working. This fixes the below error with the previous example:

```
│ Error: creating IAM Policy (rstudio-pm-20230823192221893600000002): MalformedPolicyDocument: Syntax errors in policy.
│ 	status code: 400, request id: 6448aac6-961f-4fe0-9b72-f37dfd22d78c
│ 
│   with module.rstudio-packagemanager.module.eks_blueprints_addon.aws_iam_policy.this[0],
│   on .terraform/modules/rstudio-packagemanager.eks_blueprints_addon/main.tf line 237, in resource "aws_iam_policy" "this":
│  237: resource "aws_iam_policy" "this" {
│ 
```
@Almenon Almenon requested a review from a team as a code owner August 23, 2023 20:11
@Almenon Almenon changed the title fix example docs: fix example Aug 23, 2023
@Almenon Almenon changed the title docs: fix example docs: Fix example Aug 23, 2023
@bryantbiggs bryantbiggs merged commit c218e0d into aws-ia:main Aug 30, 2023
1 of 3 checks passed
@Almenon Almenon deleted the Almenon-patch-1 branch August 31, 2023 15:39
@Almenon
Copy link
Contributor Author

Almenon commented Aug 31, 2023

Thanks!

williamsbobby1423 pushed a commit to williamsbobby1423/terraform-aws-eks-blueprints-addon that referenced this pull request Sep 25, 2023
@Almenon @williamsbobby1423
docs: Fix example (aws-ia#17)
72d1637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty policy tying to be created using module example
2 participants
@Almenon @bryantbiggs