feat: Update default chart versions to latest minor version #220
Conversation
…-addons into feat/update-versions
| @@ -1152,7 +1152,7 @@ module "aws_load_balancer_controller" { | |||
| # namespace creation is false here as kube-system already exists by default | |||
| create_namespace = try(var.aws_load_balancer_controller.create_namespace, false) | |||
| chart = try(var.aws_load_balancer_controller.chart, "aws-load-balancer-controller") | |||
| chart_version = try(var.aws_load_balancer_controller.chart_version, "1.4.8") | |||
| chart_version = try(var.aws_load_balancer_controller.chart_version, "1.5.5") | |||
There was a problem hiding this comment.
This is a breaking change.
#190 (comment)
There was a problem hiding this comment.
what is breaking about this change?
There was a problem hiding this comment.
Chart 1.4.8 points to app version v2.4.7
Chart 1.5.0+ points to app version v2.5.0+
Problem is https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/tag/v2.5.0 has breaking changes.
Also mentioned in the comment linked above pointing to my PR that I closed because of this.
There was a problem hiding this comment.
We don't consider third level dependencies in the semver of this module. Semver for this module is concerned only with the exposed interface of the module - users should not rely on the default chart versions of this module but instead pin to the version of their choosing. We will keep moving the module forward and applying updates as needed (such as this PR to update versions)
What does this PR do?
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes