Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose updateStrategy to make it configurable for cloudwatch agent and fluentbit #174

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

varunch77
Copy link

@varunch77 varunch77 commented Feb 25, 2025

Expose updateStrategy to make it configurable for cloudwatch agent and fluentbit (daemonset only)

Cloudwatch agent - output after helm upgrade:

---
# Source: amazon-cloudwatch-observability/templates/linux/cloudwatch-agent-custom-resource.yaml
apiVersion: cloudwatch.aws.amazon.com/v1alpha1
kind: AmazonCloudWatchAgent
metadata:
  name: cloudwatch-agent
  namespace: amazon-cloudwatch
spec:
  updateStrategy:
      type: OnDelete
---
# Source: amazon-cloudwatch-observability/templates/linux/cloudwatch-agent-custom-resource.yaml
apiVersion: cloudwatch.aws.amazon.com/v1alpha1
kind: AmazonCloudWatchAgent
metadata:
  name: cloudwatch-agent
  namespace: amazon-cloudwatch
spec:
  updateStrategy:
      type: RollingUpdate
      rollingUpdate:
        maxUnavailable: 1
        maxSurge: 0

FluentBit changes - output after helm upgrade --dry-run:

---
# Source: amazon-cloudwatch-observability/templates/linux/fluent-bit-daemonset.yaml
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: fluent-bit
  namespace: amazon-cloudwatch
  labels:
    k8s-app: fluent-bit
    version: v1
    kubernetes.io/cluster-service: "true"
spec:
    ...
    spec:
      ...
      priorityClassName: system-node-critical
      priorityClassName: system-node-critical
      updateStrategy:
        type: RollingUpdate
        rollingUpdate:
          maxUnavailable: 1
          maxSurge: 0
      ...
---
# Source: amazon-cloudwatch-observability/templates/linux/fluent-bit-daemonset.yaml
apiVersion: apps/v1
kind: DaemonSet
metadata:
 name: fluent-bit
 namespace: amazon-cloudwatch
 labels:
   k8s-app: fluent-bit
   version: v1
   kubernetes.io/cluster-service: "true"
spec:
   ...
   spec:
     ...
     priorityClassName: system-node-critical
     updateStrategy:
       type: OnDelete

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. ✅

@varunch77 varunch77 changed the title Make the update strategy configurable Expose updateStrategy to make it configurable for cloudwatch agent and fluentbit Feb 26, 2025
@varunch77 varunch77 merged commit 7acc673 into main-opsathon Feb 26, 2025
@varunch77 varunch77 deleted the add-update-strategy branch February 26, 2025 16:58
@zhihonl zhihonl restored the add-update-strategy branch March 5, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants