Flux update #794
Flux update #794
Conversation
zjaco13
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103,
youngjeong46 and
elamaran11
as code owners
There was a problem hiding this comment.
@zjaco13 Please check my comments. Also check on another Flux Multi path PR which has some common changes.
docs/addons/fluxcd.md
Outdated
| name: "nginx", | ||
| namespace: "default", | ||
| repository: { | ||
| repoUrl: 'https://github.com/zjaco13/flux-tester', |
There was a problem hiding this comment.
Could we use a standard repos vs pointing to your own personal repo? Something like this - https://github.com/aws-observability/aws-observability-accelerator/tree/main or PodInfo
There was a problem hiding this comment.
We can use another repo. Not sure if the observability accelerator manifests will be the best option though, because they require values and a different namespace.
There was a problem hiding this comment.
LGTM. @shapirov103 Please check this and do e2e if you are good.
There was a problem hiding this comment.
@zjaco13 looks great, I will run e2e just as a sanity check, although we don't have a direct impact on the e2e test.
|
|
||
| const nginxDashUrl = "https://raw.githubusercontent.com/aws-observability/aws-observability-accelerator/main/artifacts/grafana-dashboards/eks/nginx/nginx.json" | ||
|
|
||
| const addOn = new blueprints.addons.FluxCDAddOn({ |
There was a problem hiding this comment.
@zjaco13 was this example validated?
|
/do-e2e-tests |
still need to fix namespace issue
|
/do-e2e-tests |
|
Failure as reported:
It may be related to the actual account where we run the test, as I was not able to see a better diagnostic message. Were you able to run this successfully in your account? |
|
/do-e2e-tests |
|
@zjaco13 this PR is causing problems when using it to deploy multiple Kustomizations. Could you please review, test (against your use case) and approve #811 which fixes the mentioned problems? |
…y-multiple-kustomizations-following-pr-794 FluxCD fails to deploy multiple Kustomizations following PR #794
Issue #, if available: #694
Description of changes:
Added workload repos to flux
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.