Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop Studio Assets #30

Merged
merged 16 commits into from
May 14, 2024
Merged

Workshop Studio Assets #30

merged 16 commits into from
May 14, 2024

Conversation

Kevinwochan
Copy link
Contributor

Issue number:

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@Kevinwochan Kevinwochan requested a review from a team as a code owner February 9, 2024 01:29
@github-actions github-actions bot requested a review from sliedig February 9, 2024 01:29
Copy link

github-actions bot commented Feb 9, 2024

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change labels Feb 9, 2024
@Kevinwochan Kevinwochan removed do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change labels Mar 1, 2024
@sliedig
Copy link
Contributor

sliedig commented May 10, 2024

@Kevinwochan can you please resolve the conflicts for this PR and resubmit, I just updated the .NET 8 changes and resolved the build conflicts.

sliedig and others added 15 commits May 14, 2024 22:51
…longer creating one for each stage as this does not change. Created new templates for shared infra, splitting namespaces from images bucket. Updated templates with references to SSM parameters.
`save-state` and `set-output` commands used in GitHub Actions are deprecated and [GitHub recommends using environment files](https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/).

This PR updates the usage of `::set-output` to `"$GITHUB_OUTPUT"`

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter
Copy link
Contributor

@sliedig sliedig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sliedig sliedig merged commit f9c9763 into develop May 14, 2024
1 check passed
Copy link

undefined No related issues found. Please ensure 'pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants