kubeshark pattern #174
kubeshark pattern #174
Conversation
There was a problem hiding this comment.
@zghanem0 Looks very good. Could you please address this minor comment. Also the doc should be added to mkdocs.yaml so the website publishing automation adds the documentation to our web - https://aws-samples.github.io/cdk-eks-blueprints-patterns/
There was a problem hiding this comment.
@zghanem0 Im currently validating your pattern but your doc is misaligned for pattern. Please fix it.
There was a problem hiding this comment.
@zghanem0 I have validated the pattern, works great, wonderful day 2 Ops tooling. Fix these issues, we can merge this.
|
@zghanem0 Please fix GH Action errors. |
|
@zghanem0 Couple of more minor stuff. |
|
@zghanem0 Only concern at this point for merging this PR is, the addon is currently in your private org, so we want to know who will maintain the Kubeshark addon if its in your private repo, whats your path to move the addon to a public org like |
|
@elamaran11 I will maintain it by myself and will plan to move it under aws-samples after getting approval |
|
@zghanem0 Merging this based on your note. Please followup and update the pattern once the addon is moved to aws-samples. |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.