fix: set request timeout to 4s by default (#229)

* feat: upgrade @types/node * fix: set request timeout to 4s by default --------- Co-authored-by: Pierre Milliotte <[email protected]>
aws-samples · Apr 21, 2023 · efc0aef · efc0aef
1 parent 017089d
commit efc0aef
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
     "@types/aws-lambda": "^8.10.92",
     "@types/cookie": "^0.4.1",
     "@types/fs-extra": "^9.0.13",
-    "@types/node": "^17.0.14",
+    "@types/node": "^18.15.12",
     "aws-sdk": "^2.1354.0",
     "html-loader": "^3.1.0",
     "prettier": "^2.5.1",

diff --git a/src/lambda-edge/shared/https.ts b/src/lambda-edge/shared/https.ts
@@ -5,6 +5,8 @@ import { IncomingHttpHeaders } from "http";
 import { request, RequestOptions } from "https";
 import { Writable, pipeline } from "stream";
 
+const DEFAULT_REQUEST_TIMEOUT = 4000; // 4 seconds
+
 export async function fetch(
   uri: string,
   data?: Buffer,
@@ -15,7 +17,12 @@ export async function fetch(
     headers: IncomingHttpHeaders;
     data: Buffer;
   }>((resolve, reject) => {
-    const req = request(uri, options ?? {}, (res) =>
+    const requestOptions = {
+      signal: AbortSignal.timeout(DEFAULT_REQUEST_TIMEOUT),
+      ...(options ?? {}),
+    };
+
+    const req = request(uri, requestOptions, (res) =>
       pipeline(
         [
           res,