Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducing Event Bridge resources name length #508

Merged
merged 3 commits into from
Nov 3, 2023
Merged

reducing Event Bridge resources name length #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ebb2af
reducing name length
BastLeblanc Nov 1, 2023
4c111f4
cloudfrontnames
BastLeblanc Nov 3, 2023
994adda
rename cloudfront
BastLeblanc Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions aws/cloudformation-templates/base/cloudfront.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Resources:
Type: AWS::CloudFront::OriginAccessControl
Properties:
OriginAccessControlConfig:
Name: !Ref AWS::StackName
Name: !Sub 'retaildemostore-${AWS::Region}'
OriginAccessControlOriginType: s3
SigningBehavior: always
SigningProtocol: sigv4
Expand All @@ -76,7 +76,7 @@ Resources:
DefaultTTL: 86400
MaxTTL: 31536000
MinTTL: 86400
Name: !Ref AWS::StackName
Name: !Sub 'retaildemostore-${AWS::Region}'
ParametersInCacheKeyAndForwardedToOrigin:
CookiesConfig:
CookieBehavior: none
Expand All @@ -94,7 +94,7 @@ Resources:
CookieBehavior: none
HeadersConfig:
HeaderBehavior: none
Name: !Ref AWS::StackName
Name: !Sub 'retaildemostore-${AWS::Region}'
QueryStringsConfig:
QueryStringBehavior: all

Expand Down
8 changes: 4 additions & 4 deletions aws/cloudformation-templates/base/event-driven.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Resources:
EventBus:
Type: AWS::Events::EventBus
Properties:
Name: !Sub "${Uid}-eventbus"
Name: !Sub "${Uid}-bus"

CatchAllRule:
Type: AWS::Events::Rule
Expand All @@ -32,7 +32,7 @@ Resources:
CatchAllEventsLogGroup:
Type: AWS::Logs::LogGroup
Properties:
LogGroupName: !Sub "${Uid}-events-log"
LogGroupName: !Sub "${Uid}-log"
RetentionInDays: 120
UpdateReplacePolicy: Delete
DeletionPolicy: Delete
Expand Down Expand Up @@ -65,7 +65,7 @@ Resources:
EventArchive:
Type: AWS::Events::Archive
Properties:
ArchiveName: !Sub "${Uid}-event-archive"
ArchiveName: !Sub "${Uid}-arch"
RetentionDays: 120
SourceArn: !GetAtt EventBus.Arn
Description: "Holds a 120 day archive of events from the Retail Demo store event bus"
Expand All @@ -89,7 +89,7 @@ Outputs:
Description: "The name of the EventBridge event bus"
Value: !Ref EventBus
Export:
Name: !Sub "${Uid}-eventbus"
Name: !Sub "${Uid}-bus"
SSMParameterForEventBus:
Description: "SSM Parameter storing the EventBridge event bus name for services to use"
Value: !Ref SSMParamForEventBus
Expand Down